Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding MFT covariances in AOD associated with global muon tracks #13780

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Adding MFT covariances in AOD associated with global muon tracks #13780

wants to merge 2 commits into from
+64 −9

Conversation

mcoquet642
Copy link
Collaborator

As discussed in physics board on 21st November, we suggest to add MFT covariances associated to global muon tracks in AODs for refit and machine learning training purposes.

@mcoquet642 mcoquet642 requested review from a team as code owners December 9, 2024 08:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

alibuild commented Dec 30, 2024 •
edited
Loading

Error while checking build/O2/fullCI for 872b14f at 2025-01-01 03:44:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[52489:calib-phos-l1phase]: [02:44:41][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[52489:calib-phos-l1phase]: [02:44:41][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-phos-calib-workflow, device shutting down. Reason: Fatal error
[52489:calib-phos-l1phase]: [02:44:40][ERROR] Requested resource does not exist: http://alice-ccdb.cern.ch//PHS/Calib/BadMap/1735699480724/
[52489:calib-phos-l1phase]: [02:44:40][FATAL] Got nullptr from CCDB for path PHS/Calib/BadMap and timestamp 1735699480724
[52489:calib-phos-l1phase]: [02:44:41][ERROR] Exception while running: Fatal error. Rethrowing.
[52489:calib-phos-l1phase]: [02:44:41][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-phos-calib-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 52489 (calib-phos-l1phase) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/0ae653ba18743f1d23b16ca55b13506f6134ff91/slc8_x86-64/o2checkcode/1.0-local901/etc/modulefiles
++ cat
--

Full log here.

shahor02
shahor02 reviewed Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me, but since it concerns AOD, I think @ddobrigk should approve it.

@ddobrigk
Copy link
Contributor

ddobrigk commented Jan 8, 2025

hi @mcoquet642 , sorry for only looking at this now. The code looks okay to me - could you just confirm that this still conforms to the data increase numbers you quoted at the Physics Board, for completeness? Thank you very much and happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahor02 shahor02 shahor02 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcoquet642 @alibuild @ddobrigk @shahor02